Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix floating-point drift in oscilloscope example#24481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromQuLogic:fix-oscilloscope-drift
Nov 17, 2022

Conversation

QuLogic
Copy link
Member

PR Summary

I left this running to about 3500s and it had not drifted out of the 2s interval.

Fixes#24476

PR Checklist

Documentation and Tests

  • [n/a] Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • [n/a] API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • [n/a] Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@QuLogicQuLogic added this to thev3.6.3 milestoneNov 17, 2022
Copy link
Member

@oscargusoscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

Not merging as I thought this should go in 3.6-doc? But feel free to self merge as I trust your decision. (I thought I had finally understood the backport aspects...)

"Documentation changes (all .rst files and examples) are milestoned v3.N-doc."

@oscargus
Copy link
Member

(I guess that there can still be some drift in particular cases, but this is for sure better than the previous version and it is also good that the default setting does not drift.)

@tacaswelltacaswell merged commit8b4bee7 intomatplotlib:mainNov 17, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 17, 2022
oscargus added a commit that referenced this pull requestNov 17, 2022
…481-on-v3.6.xBackport PR#24481 on branch v3.6.x (Fix floating-point drift in oscilloscope example)
@QuLogicQuLogic deleted the fix-oscilloscope-drift branchNovember 18, 2022 00:07
@QuLogic
Copy link
MemberAuthor

You're right it can go to doc as well.

meeseeksdev backport to v3.6.x-doc

@lumberbot-app
Copy link

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@QuLogic
Copy link
MemberAuthor

Oops...

meeseeksdev backport to v3.6.2-doc

@QuLogicQuLogic modified the milestones:v3.6.3,v3.6-docNov 18, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 18, 2022
ksunden added a commit that referenced this pull requestNov 18, 2022
…481-on-v3.6.2-docBackport PR#24481 on branch v3.6.2-doc (Fix floating-point drift in oscilloscope example)
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6-doc
Development

Successfully merging this pull request may close these issues.

[Doc]: Oscilloscope demo x-axis offset
3 participants
@QuLogic@oscargus@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp