NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Draw RadioButtons using scatter to ensure circular buttons.#24455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ksunden merged 1 commit intomatplotlib:mainfromanntzer:rb

Nov 15, 2022

Merged

Draw RadioButtons using scatter to ensure circular buttons.#24455

ksunden merged 1 commit intomatplotlib:mainfromanntzer:rb

Nov 15, 2022

Conversation

Copy link

Contributor

anntzer commentedNov 14, 2022•
edited
Loading

To ensure backcompat without bothering the majority of users who don't actually access the .circles attribute, dynamically (and irreversibly) switch back to the old draw method (list of Circles) whenever that attribute is accessed for the first time (if ever).

https://matplotlib.org/stable/gallery/widgets/radio_buttons.html now looks like

Note that the buttons are now circular.

Closes#24428.

PR Summary

PR Checklist

Tests and Styling

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
New plotting related features are documented with examples.

Release Notes

New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

anntzer added the topic: widgets/UI label

Nov 14, 2022

anntzer force-pushed therb branch 2 times, most recently from26580cc tofcfae34Compare

November 14, 2022 23:05

QuLogic added this to thev3.7.0 milestone

Nov 15, 2022

anntzer force-pushed therb branch fromfcfae34 toeae36f5Compare

November 15, 2022 08:12

anntzer mentioned this pull request

Nov 15, 2022

[Bug]: RadioButtons should be circular, not elliptic#24428

Closed

timhoffm approved these changes

Nov 15, 2022

View reviewed changes

Copy link

Member

timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The fallback is very clever 👍.

anntzer force-pushed therb branch fromeae36f5 tod374631Compare

November 15, 2022 18:04

Draw RadioButtons using scatter to ensure circular buttons.

3c306a3

To ensure backcompat without bothering the majority of users who don'tactually access the .circles attribute, dynamically (and irreversibly)switch back to the old draw method (list of Circles) whenever thatattribute is accessed for the first time (if ever).

anntzer force-pushed therb branch fromd374631 to3c306a3Compare

November 15, 2022 18:08

ksunden approved these changes

Nov 15, 2022

View reviewed changes

ksunden merged commitbcdd07a intomatplotlib:main

Nov 15, 2022

anntzer deleted the rb branch

November 15, 2022 22:13

anntzer mentioned this pull request

Nov 15, 2022

[Bug]: CheckBoxes should be square, not rectangular#24471

Closed

timhoffm mentioned this pull request

Nov 17, 2022

Use scatter for check boxes and set facecolors correctly in check boxes and radio buttons#24474

Merged

6 tasks

Copy link

drammock commentedNov 17, 2022•
edited
Loading

What is the recommendation for those of us (MNE-Python) whodo access the.circles property? AFAICT from the diff there isn't an alternative in the public API ofRadioButtons after this PR (but maybe I'm not looking carefully enough?)

If it helps, here is an example of what we do with it:

https://github.com/mne-tools/mne-python/blob/e65e5e5b49a7cdc21fb42d4a92bca5bd7a4e4329/mne/viz/_mpl_figure.py#L1050-L1061

we actually access.circles ten times in that file; some of them are simple one-liners to get a button's color, others are more complex like the snippet above.

drammock mentioned this pull request

Nov 17, 2022

add initial demo of iterative sphere coloringmne-tools/mne-python#11281

Merged

larsoner mentioned this pull request

Nov 18, 2022

MAINT: Matplotlib deprecation of buttons.circlesmne-tools/mne-python#11332

Closed

Copy link

Member

QuLogic commentedDec 2, 2022

If I've understood what that code does, it appears that you set a radius so that the buttons are reasonably sized. And the second thing is setting specific edge colours for each radio? I think the former is something we should just do, and the latter (styling options) is a reasonable enhancement request if you want to open an issue?

drammock mentioned this pull request

Dec 2, 2022

[ENH]: provide public API for styling radio buttons#24583

Closed

Copy link

drammock commentedDec 2, 2022

If I've understood what that code does, it appears that you set a radius so that the buttons are reasonably sized. And the second thing is setting specific edge colours for each radio? I think the former is something we should just do, and the latter (styling options) is a reasonable enhancement request if you want to open an issue?

Another thing we do is apply transforms to ensure buttons are circular. That part should go be able to be removed after this PR, but we'll still want to be able to set size and linewidth (on all buttons uniformly) and set color, edgecolor, and opacity (on each button individually). I've opened#24583 for the feature request.