Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: add example of spinning circle icon animation#24448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

joAschauer
Copy link

PR Summary

Adds an example to the animations section showing an animated spinning circle loading icon.

Documentation failed to build locally due to some latex error in the examplemisc/multipage_pdf.py. The added example is working when run individually.

PR Checklist

Tests and Styling

  • [N/A ] Has pytest style unit tests (andpytest passes).
  • [N/A ] IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A ] New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • [N/A ] API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • [N/A ] Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
@jklymak
Copy link
Member

Can you advocate for this a bit more? What new does this bring to the already existing examples? Thanks!

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@tacaswell
Copy link
Member

xref#24274

Thank you for your work on this@joAschauer !

In general our documentation suffers from both the problem that we do not have enough (there are things that should be documented that are not) and too much (it is hard to actually find the thing you need!). While this is very cool example, why do you think this helps the first problem (not enough docs) without making the second worse (too much docs)?

I'm a bit worried about the multipdf failures...

@joAschauer
Copy link
Author

I did not find a combination of Axes.vlines and polar projection in the documentation. Maybe good to show this somewhere, although it is already answered on stackoverflow (https://stackoverflow.com/a/36828129). If you think this does not add enough value and rather clutters the examples, feel free to close the PR.

@joAschauer
Copy link
Author

Maybe better to make a proper animation tutorial (#24274) than adding more and more examples. I leave it up to you if this should be included or not.

@jklymak
Copy link
Member

@joAschauer Thanks a lot for this. OTOH, I'm not clear why it is an animation, nor particularly why the static demonstration is needed. I don't think we need every plotting method repeated in polar co-ordinates, and adding vlines doesn't seem particularly complicated? But likely I am missing a subtlety?

@jklymakjklymak added the status: needs clarificationIssues that need more information to resolve. labelJan 30, 2023
@jklymakjklymak marked this pull request as draftFebruary 2, 2023 17:36
@jklymak
Copy link
Member

Moved to draft until we get more explanation.

@joAschauer
Copy link
Author

Hi@jklymak and sorry for the late reply.

You are right, adding vlines to a polar plot is not complicated, but I personally like to learn from examples.

Sometimes I wonder how something would be done in matplotlib and I play around. The same was true for the spinning circles waiting icon on my phone, which is animated. Since I liked the result, I thought it could be shared with others and opened this PR. As I feel you think it goes beyond the scope of the examples and doesn't add enough value, I am going to close this pull request.

@jklymak
Copy link
Member

Perhaps it would be good in the showcase athttps://discourse.matplotib.org?

Our example library is very large, so we need to be somewhat selective in choosing what to add. Thanks for your understanding.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell left review comments

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees
No one assigned
Labels
status: needs clarificationIssues that need more information to resolve.
Projects
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@joAschauer@jklymak@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp