Closes#24433

PR Summary

The method name forFigure.legend inpyplot isfiglegend due to a name collision.
As such, a.replace call is used to translate the docstring from the one written forFigure.legend to make sense for users interacting withplt.figlegend.

This behavior was originally introduced in#11975, usinglegend( alone (with no dotted name).

The docstring was updated in#18106, with additional examples that usedfig.legend( in additional examples.
These new examples were caught by the replace and becamefig.figlegend(.

This PR makes all callsfig.legend and simply removes the dot for the replace call.
This leads to someslightly incongrous examples which are using the object based api to callax.plot but following that withfiglegend frompyplot. (notwrong per se, but mixing APIs)
This was chosen as a compromise to allow the docstring to have one cannonical form, while still using the method name wherehelp is called.

PR Checklist

Tests and Styling

• Has pytest style unit tests (andpytest passes).
• IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

• Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
• New plotting related features are documented with examples.

Release Notes

• New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
• API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
• Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst