Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Programmatically generate signature of Figure.savefig.#24405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
anntzer wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromanntzer:pss

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedNov 9, 2022
edited
Loading

Note that the previously documented "Call signature" did not mention "transparent".

Also adjust tools/boilerplate.py so that pyplot.savefig can also benefit from this change; this implies generalizing
axes_cmappable_method_template to support general postambles, also for Figure methods.

See the new signature of pyplot.savefig for the end result.


Edit: This currently fails test_agg.py::test_webp_alpha because facecolor=None is now explicitly passed to Figure.savefig, which preventskwargs.setdefault("facecolor", "none") from taking effect, andfacecolor=None is instead interpreted as "use the rcparam" :/ Probably easy to fix, but needs some thought about strict backcompat.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

Note that the previously documented "Call signature" did not mention"transparent".Also adjust tools/boilerplate.py so that pyplot.savefig can also benefitfrom this change; this implies generalizingaxes_cmappable_method_template to support general postambles, also forFigure methods.See the new signature of pyplot.savefig for the end result.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@anntzer

[8]ページ先頭

©2009-2025 Movatter.jp