Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Userepr in error message Addresses #21959#24403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 6 commits intomatplotlib:mainfromjefromyers:repr-instead-of-str
Nov 10, 2022

Conversation

@jefromyers
Copy link
Contributor

Implements the proposed solution in issue#21959. Error message now outputs the user’s input viarepr.

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A] New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • [N/A] API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • [N/A] Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@story645story645 linked an issueNov 8, 2022 that may beclosed by this pull request
@QuLogic
Copy link
Member

Do you mind if I squash merge this PR, or would you like to?

@jefromyers
Copy link
ContributorAuthor

feel free to squash, sir. thanks for your help.

@QuLogicQuLogic added this to thev3.7.0 milestoneNov 10, 2022
@QuLogicQuLogic merged commit04ce3e9 intomatplotlib:mainNov 10, 2022
@QuLogic
Copy link
Member

Thanks@jefromyers! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

@QuLogicQuLogic mentioned this pull requestNov 10, 2022
melissawm pushed a commit to melissawm/matplotlib that referenced this pull requestDec 19, 2022
* use repr in error messageclosesmatplotlib#21959* add test for repr error message* fix formatting* clean up formatting and naming* add `pragma: no cover`* remove import and function name a bit more explicit
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicQuLogic approved these changes

@story645story645story645 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

[ENH]: Userepr instead ofstr in the error message

3 participants

@jefromyers@QuLogic@story645
[8]ページ先頭
©2009-2025 Movatter.jp