Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: Cleanup Spine placement example#24377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromtimhoffm:doc-spine-positions
Nov 6, 2022

Conversation

timhoffm
Copy link
Member

  • usesubplot_mosaic() instead ofsubplot(n, m, k) calls
  • hide spines usingset_visible(False) instead ofset_color('none')
  • use multi-assignment (spines[['left', 'bottom']].set_*) when possible
  • removeax.xaxis.set_ticks_position('bottom') andax.yaxis.set_ticks_position('left'), because these are already the defaults
  • reference the example inspine_set_positions() docstring

@timhoffmtimhoffm added this to thev3.6.3 milestoneNov 6, 2022
- use `subplot_mosaic()` instead of `subplot(n, m, k)` calls- hide spines using `set_visible(False)` instead of `set_color('none')`- use multi-assignment (`spines[['left', 'bottom']].set_*`) when  possible- remove `ax.xaxis.set_ticks_position('bottom')` and  `ax.yaxis.set_ticks_position('left')`, because these are already the  defaults- reference the example in `spine_set_positions()` docstring
@tacaswell
Copy link
Member

https://output.circle-artifacts.com/output/job/d0c88874-3987-4de0-8354-b71a50bbba6b/artifacts/0/doc/build/html/gallery/spines/spine_placement_demo.html

vs

https://matplotlib.org/stable/gallery/spines/spine_placement_demo.html

Is the change.

I was momentarily thrown by the change from [-pi, pi] for the range to [0, 2pi].

@timhoffm can self-merge if that was a reasoned choice.

@tacaswelltacaswell modified the milestones:v3.6.3,v3.6-docNov 6, 2022
@timhoffm
Copy link
MemberAuthor

That change is intentional. Sorry that I forgot to list and explain it. For a 0-symmetric x range, „center“ and „zero“ modes have the same effect. Going to [0, 2pi] makes the difference obvious.

@timhoffmtimhoffm merged commit9dbcbe2 intomatplotlib:mainNov 6, 2022
@timhoffmtimhoffm deleted the doc-spine-positions branchNovember 6, 2022 09:54
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 6, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 6, 2022
jklymak added a commit that referenced this pull requestNov 7, 2022
…377-on-v3.6.xBackport PR#24377 on branch v3.6.x (DOC: Cleanup Spine placement example)
jklymak added a commit that referenced this pull requestNov 7, 2022
…377-on-v3.6.2-docBackport PR#24377 on branch v3.6.2-doc (DOC: Cleanup Spine placement example)
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6-doc
Development

Successfully merging this pull request may close these issues.

2 participants
@timhoffm@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp