Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: Improve Image Slices Viewer example#24366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

timhoffm
Copy link
Member

PR Summary

closes#24360

@timhoffmtimhoffm added this to thev3.6.3 milestoneNov 4, 2022
Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We have that handle persistence note somewhere else as well. Do we need to find other places for it?

@timhoffm
Copy link
MemberAuthor

We have that handle persistence note somewhere else as well. Do we need to find other places for it?

Do you mean add a note other places where we need to keep objects alive?

One coud do that. There's at least the following examples with similar patterns in theEvent handling examples:

plus probably additional ones inWidgets.

However, this is beyond what I'm willing to do right now. We can open an issue for it.

On a general note, I'm not very convinced of this pattern to create a complex object and bind it's methods to a figure. IMHO it would make more sense for theImageTracker to create and own the figure.

@tacaswell
Copy link
Member

On a general note, I'm not very convinced of this pattern to create a complex object and bind it's methods to a figure. IMHO it would make more sense for the ImageTracker to create and own the figure.

The pattern of an independent object that knows about the Figure and provides some interaction does match how I have frequently used this sort of thing. I've either hand a couple of these that I turn on and off or have been embedding in a larger GUI where if each one tried to make its ownFigure object it would have caused some trouble for me.

I'm also wary of going to pure-functions because in my experience I have wanted to pull state off of these classes.

@timhoffmtimhoffm deleted the doc-image-slice-viewer branchNovember 6, 2022 09:36
timhoffm added a commit that referenced this pull requestNov 6, 2022
…366-on-v3.6.xBackport PR#24366 on branch v3.6.x (DOC: Improve Image Slices Viewer example)
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.3
Development

Successfully merging this pull request may close these issues.

[ENH]: imshow support for multiple slice image volume
3 participants
@timhoffm@tacaswell@jklymak

[8]ページ先頭

©2009-2025 Movatter.jp