Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Restore get_renderer function in deprecated tight_layout#24301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromoscargus:restoregetrenderer
Nov 2, 2022

Conversation

@oscargus
Copy link
Member

PR Summary

get_renderer was removed in#22745 despite being a public (listed) function, see#24300 (comment)

Closes#24300

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@oscargusoscargus added this to thev3.6.2 milestoneOct 29, 2022
@oscargusoscargus marked this pull request as ready for reviewOctober 29, 2022 10:52
@oscargusoscargus changed the titleRestore get_rendered function in deprecated tight_layoutRestore get_renderer function in deprecated tight_layoutOct 29, 2022
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe better restore the method to the non-private module?

@oscargus
Copy link
MemberAuthor

You are both right. I was, incorrectly, under the impression that the module would be removed once the deprecation expires. Thanks for thinking!

Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Leaving open if@timhoffm wanted to comment further.

@QuLogicQuLogic merged commitf26219b intomatplotlib:mainNov 2, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 2, 2022
QuLogic added a commit that referenced this pull requestNov 2, 2022
…301-on-v3.6.xBackport PR#24301 on branch v3.6.x (Restore get_renderer function in deprecated tight_layout)
@oscargusoscargus deleted the restoregetrenderer branchNovember 2, 2022 07:44
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@anntzeranntzeranntzer left review comments

@timhoffmtimhoffmtimhoffm approved these changes

@rcomerrcomerrcomer left review comments

@QuLogicQuLogicQuLogic approved these changes

@jklymakjklymakjklymak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.6.2

Development

Successfully merging this pull request may close these issues.

cannot import name 'get_renderer' from 'matplotlib.tight_layout

6 participants

@oscargus@QuLogic@anntzer@jklymak@timhoffm@rcomer
[8]ページ先頭
©2009-2025 Movatter.jp