Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Remove comment about cmap from voxels docstring#24284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
voxels does not use cmap at all, and thus does not modify shade in relation to cmap being passed in, this appears to be copy/pasted from methods which _do_ use cmap
tacaswell commentedOct 27, 2022
It does not fall through to the underlying |
story645 commentedOct 27, 2022
ksunden commentedOct 27, 2022
@tacaswell Poly3DCollection makes no references to cmaps whatsoever, relying on the higher level functions to call the map to get facecolors. In fact the light source shading itself is even done in The data for voxels is fundamentally binary (show this voxel or don't) and so don't map onto a cmap. Granted, the For reference, I noticed this while looking into#24277, where the reporter is requesting pretty much exactly that. its easy enough to work around with the tools provided, and bringing in norms and all of the color-focused arguments may be more effort than we wish. |
tacaswell commentedOct 27, 2022
This is another candidate for |
…284-on-v3.6.xBackport PR#24284 on branch v3.6.x (Remove comment about cmap from voxels docstring)
PR Summary
voxelsdoes not usecmapat all, and thus does not modifyshadein relation tocmapbeing passed in, this appears to be copy/pasted from 3D methods whichdo usecmap.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst