Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix some minor docstring typos#24282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromQuLogic:docstring-typos
Nov 1, 2022

Conversation

QuLogic
Copy link
Member

PR Summary

Found while testing outflake8-rst (for which there are unfortunately a few too many false positives.)

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • [n/a] API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • [n/a] Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

>>> fig.show()

>>> selector.add_state('square')
>>>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
>>>

?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suspected the extra line was there to emphasize it, but I'm not sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It starts a new box, so probably, yes. I'm more wondering about the rationale to put an empty command-line/return-press instead. Better to drop it completely then?

timhoffm reacted with thumbs up emoji
@ksundenksunden added this to thev3.6.2 milestoneNov 1, 2022
@timhoffmtimhoffm merged commit14c50c8 intomatplotlib:mainNov 1, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 1, 2022
tacaswell added a commit that referenced this pull requestNov 1, 2022
…282-on-v3.6.xBackport PR#24282 on branch v3.6.x (Fix some minor docstring typos)
@QuLogicQuLogic deleted the docstring-typos branchNovember 1, 2022 22:23
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@oscargusoscargusoscargus left review comments

@ksundenksundenksunden approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.2
Development

Successfully merging this pull request may close these issues.

4 participants
@QuLogic@ksunden@timhoffm@oscargus

[8]ページ先頭

©2009-2025 Movatter.jp