Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix hatch linewidth in PGF#24263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
oscargus wants to merge2 commits intomatplotlib:main
base:main
Choose a base branch
Loading
fromoscargus:pgfhatchlinewidth

Conversation

oscargus
Copy link
Member

Co-authored-by: Antony Leeanntzer.lee@gmail.com

PR Summary

Closes#15491

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

daeh reacted with hooray emoji
@oscargusoscargus marked this pull request as ready for reviewOctober 24, 2022 16:05
@oscargus
Copy link
MemberAuthor

Not obvious why this kills all Linux tests, but no Windows or Mac tests.

@oscargus
Copy link
MemberAuthor

This looks extremely fragile. After a rebase I get even more errors... Especially, it seems like the conversion from PDF to PNG is affected for some unknown reason.

An example:

Screenshot of expected PDF
image

Screenshot of resulting PDF
image

These look quite the same IMHO.

PNG of expected PDF
fancy-expected_pdf

PNG of resulting PDF
fancy_pdf

Expected PNG for reference
fancy-expected

@oscargus
Copy link
MemberAuthor

I cannot run the whole test suite locally in one go as I get aFatal Python error: Illegal instruction every now and then. Most tests that fails here pass locally though (some minor, single pixel type of errors).

However, I noted this error from the test log:

! Package geometry Error: \paperheight (0.72229pt) too short.See the geometry package documentation for explanation.Type  H <return>  for immediate help. ...                                                                                                l.1006 \Gm@process                  No pages of output.Transcript written on figure.log.and the following error:

So it may indeed be related to what was discussed during the dev call: something messes up the ghostscript conversion process that propagates among the tests.

@oscargusoscargus marked this pull request as draftNovember 3, 2022 21:55
@tacaswell
Copy link
Member

Fatal Python error: Illegal instruction

Those tend to come from binaries compiled with CPU instruction sets that your CPU does not have...and I have mostly seen them with mkl or other "go fast" numpy extensionss....

@oscargusoscargusforce-pushed thepgfhatchlinewidth branch 3 times, most recently from1c7cd9f to4b2dc96CompareNovember 6, 2022 11:23
@oscargusoscargus mentioned this pull requestJan 24, 2025
2 tasks
@story645
Copy link
Member

Hi@oscargus any plans to finish this up? Particularly so that#29392 can get rebased on it?

@oscargus
Copy link
MemberAuthor

I'd be happy to finish it. Just that I do not really know what remains to be done and/or what causes the weird inconsistent test images.

But I'll try to rebase it and see what the current status is and if anything has changed.

story645 and daeh reacted with thumbs up emoji

Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hatch line width ignored with pgf backend
3 participants
@oscargus@tacaswell@story645

[8]ページ先頭

©2009-2025 Movatter.jp