callback cannot be None, so it doesn't make sense to have a default value (despite this going back 17 years...).

I'm inclinded that we wantcallback keyword-only as well.

FYI you can have keyword-only arguments without a default. This is valid:

def __init__(self, ax, xy, *, callback, useblit=True):

and would be called as

Lasso(ax, xy, callback=foo)

However, to be checked whethermake_keyword_only does work correctly for such a situation.

I'm a bit skeptical of changing callback to be keyword only. The only place we use this in a demo it is passed positionally. I am worried that we are going to get minor payoff at the cost of thrashing a bunch of user code.

I would not make it kwonly; it should be pretty clear in the context that that argument is a callback. The point of making e.g. useblit kwonly is that if you writeLasso(ax, xy, somefunc, True), it is really not clear whatTrue is (useblit=True is clearer), but it is quite obvious that somefunc is a callback (especially as it'll typically have a more meaningful name, e.g. onselect; if it's a lambda defined inline (Lasso(ax, xy, lambda vertices: ...)) the situation is also clear).

onselect cannot beNone (and isn't in any other Selector).

I'm inclinded that we wantcallback keyword-only as well.

FYI you can have keyword-only arguments without a default. This is valid:

def __init__(self, ax, xy, *, callback, useblit=True):

and would be called as

Lasso(ax, xy, callback=foo)

However, to be checked whethermake_keyword_only does work correctly for such a situation.

Removal ofTextBox.DIST_FROM_LEFT is missing.

FWIW this is all just copied and pasted from the 3.5 release notes and deprecated replaced with removed (more or less).

But I will of course edit accordingly.

Looks like this was deprecated inbd9ee5e but we did not get a API change note with it.

Should I update this to be deprecated in 3.7?

It has been warning, but was not documented. The conservative thing to do is put it back, document it removed in 3.7 and drop it in 3.8, but I'm inclined to be a bit YOLO here and just document that it is removed in 3.7 as this is a very niche feature...