Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update example and docstring to encourage the use of functools.partial in FuncAnimation#24238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 4 commits intomatplotlib:mainfromoscargus:mpl-20326
Nov 1, 2022

Conversation

oscargus
Copy link
Member

PR Summary

Fixes#20326
Closes#20358
Closes#24139

Merged contents from#20358 and#24139 with comments. Probably have missed something...

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@tacaswell
Copy link
Member

I would prefer to show passing the artist in via the partial rather than the data. The goal is to be able to write (or import) your update function in a way that does not require it to be able to capture the artist to be updated in the closure.

story645 reacted with thumbs up emoji

Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
@oscargus
Copy link
MemberAuthor

Am I right in believing that the example is now doing that? (I fixed a few things to make it work...)

@oscargus
Copy link
MemberAuthor

Can someone please have a final look at this?

@ksundenksunden added this to thev3.6.2 milestoneNov 1, 2022
@ksundenksunden merged commit185a421 intomatplotlib:mainNov 1, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 1, 2022
…ge the use of functools.partial in FuncAnimation
timhoffm added a commit that referenced this pull requestNov 1, 2022
…238-on-v3.6.xBackport PR#24238 on branch v3.6.x (Update example and docstring to encourage the use of functools.partial in FuncAnimation)
@oscargusoscargus deleted the mpl-20326 branchNovember 2, 2022 07:44
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell left review comments

@QuLogicQuLogicQuLogic approved these changes

@anntzeranntzeranntzer left review comments

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.2
Development

Successfully merging this pull request may close these issues.

FuncAnimation Named Arguments
6 participants
@oscargus@tacaswell@QuLogic@anntzer@ksunden@jeffreypaul15
[8]ページ先頭
©2009-2025 Movatter.jp