Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MNT: Update pre-commit hooks#24196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
MNT: Update pre-commit hooks#24196
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Summary of why each of these changes is applied:
| @@ -4,13 +4,18 @@ ba | |||
| cannotation | |||
| coo | |||
| curvelinear | |||
| dedented | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Use in
| dedented docstring; additional replacements can by given in *doc_sub*. |
is reasonable so adding to ignore.
| @@ -4,13 +4,18 @@ ba | |||
| cannotation | |||
| coo | |||
| curvelinear | |||
| dedented | |||
| falsy | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Falsy is how Python spells it, so adding.
| flate | ||
| hax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Use in
| fig, (vax,hax)=plt.subplots(1,2,figsize=(12,6)) |
for "horizontal axis" is reasonable, so added. However, if it would be preferable to make the example variables more explicit and verbose I can edit them instead.
| hist | ||
| inh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Use in
matplotlib/lib/matplotlib/transforms.py
Line 2562 in23730b4
| inl,inb,inw,inh=self._boxin.bounds |
for "invalid height" is reasonable, so added.
Uh oh!
There was an error while loading.Please reload this page.
| nd | ||
| oly | ||
| sur | ||
| resizeable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Use in
| artist resizeable, moveable, highlightable, and selectable as desired |
is a valid spelling, and so adding to ignore file.
sur is removed as added to thecodespell dictionary inv2.2.0. c.f.codespell-project/codespell#2300
As this is a follow up to PR#22809, then tagging@oscargus,@greglucas,@jklymak, and@QuLogic for possible reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good! Replaces#24086?
matthewfeickert commentedOct 17, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
To me it seems like just closing#24086 when this is merged would be the way to go. |
matthewfeickert commentedOct 17, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
That's totally fine! The pre-commit.ci bot doesn't care at all. I'll just be better in the future about checking for those PRs before opening another one. I've updated the PR body to close PR#24086 automatically now. |
bb6702b to7e2b17cCompare* github.com/pycqa/flake8: v4.0.1 → v5.0.4* github.com/codespell-project/codespell: v2.1.0 → v2.2.2
* Use 'name' to additionally avoid codespell failure.
Ignore instances of:* 'dedented', 'resizeable'* 'falsy' for Falsy in Python* 'hax' for horizontal axis* 'inh' for invalid heightRemove ignore of 'sur' as it is in codespell's dictionary as of v2.2.0. - c.f.https://github.com/codespell-project/codespell/releases/tag/v2.2.0
7e2b17c tob41e130Compare
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Update the
codespellpre-commit hook, and while doing so also update theflake8pre-commit hook.Note that this PR would eventually be done by the quarterly update, and so feel free to close if you'd prefer to wait for that, but this takes care of additional updates now.
Follow up PR to PR#22809.
Closes#24086
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).