NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Do not pass width_ratios or height_ratios to inner layouts in subplot_mosaic#24188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

joshbarrass wants to merge5 commits intomatplotlib:mainfromjoshbarrass:main

Closed

Do not pass width_ratios or height_ratios to inner layouts in subplot_mosaic#24188

joshbarrass wants to merge5 commits intomatplotlib:mainfromjoshbarrass:main

Conversation

Copy link

Contributor

joshbarrass commentedOct 16, 2022•
edited
Loading

PR Summary

Fixes#24099

Constructs a newgridspec_kw dictionary with the"width_ratios" and"height_ratios" removed, which is passed to the inner layouts instead of the original. This prevents an error from occurring when one of the inner layouts is not compatible with one of the specified ratios.

PR Checklist

Tests and Styling

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

[N/A] New features are documented, with examples if plot related.
[N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

joshbarrass added4 commits

October 16, 2022 15:04

Do not pass width/height ratios to nested layouts

8522e9e

Add test case for width_ratios

666ab55

Add test case for height_ratios

57a0a01

Add behaviour change file

e23ebe3

joshbarrass marked this pull request as draft

October 16, 2022 14:47

github-actionsbot reviewed

Oct 16, 2022

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.