Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Don't simplify paths used for autoscaling#24177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Path simplification is really scaled for pixel/display unit outputs, butpaths in autoscaling are in data units. This sometimes causesautoscaling to pick the wrong limits, as the simplified paths may besmaller than the originals.Fixesmatplotlib#24097
oscargus approved these changesOct 15, 2022
anntzer approved these changesOct 15, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 15, 2022
QuLogic added a commit that referenced this pull requestOct 17, 2022
…177-on-v3.6.xBackport PR#24177 on branch v3.6.x (Don't simplify paths used for autoscaling)
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Path simplification is really scaled for pixel/display unit outputs, but paths in autoscaling are in data units. This sometimes causes autoscaling to pick the wrong limits, as the simplified paths may be smaller than the originals.
This uses a simplified copy of the bin paths from#24097, skipping the whole random generation and histogram step in favour hardcoding the array.
Fixes#24097
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).