Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DOC]: add parent link forFuncAnimation andArtistAnimation#24169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
oscargus merged 2 commits intomatplotlib:mainfromkwsp:animation_doc
Oct 18, 2022
Merged

[DOC]: add parent link forFuncAnimation andArtistAnimation#24169

oscargus merged 2 commits intomatplotlib:mainfromkwsp:animation_doc
Oct 18, 2022

Conversation

kwsp
Copy link
Contributor

@kwspkwsp commentedOct 14, 2022
edited
Loading

PR Summary

#24150 (comment)

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).No code changes
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@kwsp
Copy link
ContributorAuthor

I'm currently having trouble building matplotlib on my machine, and so I cannot build the docs that reflect the changes I made.

#24168

@kwspkwsp marked this pull request as ready for reviewOctober 14, 2022 23:41
@oscargus
Copy link
Member

Closing and reopening to retrigger docs build. (PR looks OK, not sure what causes the CircleCI error. Happens sometimes.)

Copy link
Member

@oscargusoscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure why the doc build directly fails. Looks good though!

(I think the description is better than before, even if we provides inherited members.)

@story645story645 added this to thev3.6.2 milestoneOct 16, 2022
@oscargus
Copy link
Member

I'll merge this as I do not understand what causes the completely failed doc-build...

Thanks@kwsp and congratulations on your first merged PR in Matplotlib! Hope to see your around!

kwsp reacted with laugh emoji

@oscargusoscargus merged commit007c4c1 intomatplotlib:mainOct 18, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 18, 2022
@oscargusoscargus changed the title[DOC]: added parent link forFuncAnimation andArtistAnimation[DOC]: add parent link forFuncAnimation andArtistAnimationOct 18, 2022
tacaswell added a commit that referenced this pull requestOct 18, 2022
…169-on-v3.6.xBackport PR#24169 on branch v3.6.x ([DOC]: added parent link for `FuncAnimation` and `ArtistAnimation`)
@kwsp
Copy link
ContributorAuthor

@oscargus thanks!

@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@story645story645story645 approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.2
Development

Successfully merging this pull request may close these issues.

3 participants
@kwsp@oscargus@story645

[8]ページ先頭

©2009-2025 Movatter.jp