There seems to be a change in numpy 1.24 where sometimesgetmask does not return an array. By usinggetmaskarray an array is guaranteed to be returned.

This PR is a bit speculative. It should not break anything, but may not really help as it may be that this change is never triggered (with current test data). On the other hand, it may help for certain input data (not clear which).

Will be interesting to see test coverage for the changes as experience shows that not all the masked stuff is tested everyhwhere.

PR Checklist

Tests and Styling

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

New features are documented, with examples if plot related.
New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Replace getmask with getmaskarray

059a7fe

oscargus marked this pull request as ready for review

October 7, 2022 10:14

Copy link

MemberAuthor

oscargus commentedOct 7, 2022

Everything seems tested and passes.

tacaswell added this to thev3.7.0 milestone

Oct 7, 2022

Copy link

Member

tacaswell commentedOct 7, 2022

I propose we merge this to main.

If we have more issues with masked arrays and new numpy we have this in our backpocket to backport if needed but we do not put speculative changes on the bug-fix branch.

Copy link

Member

tacaswell commentedOct 7, 2022

I am weakly against merging this. In all of these cases we are grabbing the mask, but then passing it straight back into numpy. If there is no mask (which numpy internally stores as numpy's version ofFalse), then there is no need to pay the cost to expand that to an array of bools to pass it back into numpy.

I do think we should take the simplifications where we in-line thegetmask calls.