Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix mask lookup in fill_between for NumPy 1.24+#24115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromQuLogic:fix-maskarray-np124
Oct 7, 2022

Conversation

QuLogic
Copy link
Member

PR Summary

I did not bother adding any new tests, as the existing tests will already break with the latest nightly NumPy wheels.

Fixes#24106

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@QuLogicQuLogic added this to thev3.6.1 milestoneOct 7, 2022
@oscargus
Copy link
Member

Semi-related: there are still uses ofgetmask in other parts of the code. Would it be worthwhile revisiting those and replace withgetmaskarray? I assume that most of the time we do want an array and that many of those may break with the "wrong" input data?

timhoffm reacted with thumbs up emoji

@timhoffmtimhoffm merged commit6f137b9 intomatplotlib:mainOct 7, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 7, 2022
@QuLogicQuLogic deleted the fix-maskarray-np124 branchOctober 7, 2022 08:07
@QuLogic
Copy link
MemberAuthor

Possibly, but none of them triggered a test failure with latest NumPy wheels, other than this one.

@oscargusoscargus mentioned this pull requestOct 7, 2022
6 tasks
QuLogic added a commit that referenced this pull requestOct 7, 2022
…115-on-v3.6.xBackport PR#24115 on branch v3.6.x (Fix mask lookup in fill_between for NumPy 1.24+)
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.

[Bug]: fill_between gives IndexError with numpy 1.24.0.dev
3 participants
@QuLogic@oscargus@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp