This is the only part of thepyproject.toml transition that is required for thepybind11 progress to continue. So after this is merged work can continue on bothpyproject.toml andpybind11 independently.

Simplest pyproject.toml containing [build-system] only

c127355

Copy link

MemberAuthor

ianthomas23 commentedOct 7, 2022•
edited
Loading

For C/C++ coverage to work, need a CI build using--no-build-isolation as otherwise the.gcno files are created in the isolated build environment which is then deleted.

Edit: The above is no longer true, now if coverage is enabled this PR stores.o and.gcno files outside of the isolated build environment so coverage works regardless of--no-build-isolation or not.

I think we will probably need to use--no-build-isolation for the minimal versions CI run, so that is the obvious CI run to play with.

ianthomas23 added3 commits

October 7, 2022 17:44

Don't use build isolation on minimum versions CI run

54efcae

Temporarily pin setuptools in GHA

b06715a

Use local dir for build_temp if coverage enabled

bdfd2ff

ianthomas23 force-pushed thesimple_pyproject branch fromda8b828 tobdfd2ffCompare

October 9, 2022 16:11

ianthomas23 added3 commits

October 9, 2022 21:10

Edit matplotlibrc in place if editable mode install

ff16e05

Don't update matplotlibrc at all if editable_mode

a925f04

Improved comments

0e97a90

Copy link

MemberAuthor

ianthomas23 commentedOct 11, 2022

This is now working as expected, and is the smallest set of changes needed to usepyproject.toml's[build-system]. All of the GitHub Actiontest runs except for the minimum versions one now use build isolation, i.e. build in a temporary isolated virtual environment to create a wheel and that wheel is then installed in the current working environment. The minimum versions test run does not use build isolation so that it builds against the already installed minimum versions of dependencies.

ianthomas23 commented

Oct 11, 2022

View reviewed changes

setup.py

		@@ -208,8 +217,9 @@ def update_matplotlibrc(path):
		class BuildPy(setuptools.command.build_py.build_py):
		def run(self):
		super().run()
		update_matplotlibrc(
		Path(self.build_lib, "matplotlib/mpl-data/matplotlibrc"))
		if not self.editable_mode:

Copy link

MemberAuthor

ianthomas23Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It surprised me to discover that when you build themain branch in editable mode thisrun function is not called. This branch does call therun function so here I am explicitly avoiding theupdate_matplotlibrc call when in editable mode to give the same behaviour asmain branch.

Copy link

Member

timhoffmOct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Editable (via pip/setuptools) is quite different from a regular build. I'm not an expert there, but have the feeling that if in doubt expectations on editable installs do not hold. Possiblypep660 will change that.