Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

MNT: make orphaned colorbar deprecate versus raise#24088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jklymak
Copy link
Member

PR Summary

Closes#23973 where we, without warning, started raising if a colorbar's mappable had no axes. This adds a deprecation, and otherwise restores the previous behaviour.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@jklymakjklymak requested a review fromQuLogicOctober 3, 2022 22:26
@jklymakjklymak added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelOct 3, 2022
@jklymakjklymak added this to thev3.6.1 milestoneOct 3, 2022
@jklymakjklymakforce-pushed thefix-deprecate-colorbar-orphan branch from4ed5aa5 to06ecfd4CompareOctober 4, 2022 00:11
@QuLogicQuLogic changed the titleMNT: make orphaned colorbar depreacte versus raiseMNT: make orphaned colorbar deprecate versus raiseOct 4, 2022
Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Probably should fix the typo in the commit message if you make this change also.

@jklymakjklymakforce-pushed thefix-deprecate-colorbar-orphan branch from06ecfd4 to7fb75e0CompareOctober 4, 2022 01:18
@tacaswell
Copy link
Member

Do we need to add or update an API change note?

I'm going to go ahead and merge this to move things along and we can follow up with another PR if we need to update docs.

@jklymak
Copy link
MemberAuthor

Yes, good question - I don't think we should change the existing API note, but maybe need a new one?

@jklymakjklymak deleted the fix-deprecate-colorbar-orphan branchOctober 6, 2022 18:15
QuLogic added a commit that referenced this pull requestOct 6, 2022
…088-on-v3.6.xBackport PR#24088 on branch v3.6.x (MNT: make orphaned colorbar deprecate versus raise)
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.

[Bug]: ValueError: Unable to determine Axes to steal space for Colorbar.
3 participants
@jklymak@tacaswell@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp