Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DOC]: adding a grid to the style sheet reference.#24020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 6 commits intomatplotlib:mainfromkostyafarber:issue-23601
Oct 1, 2022

Conversation

kostyafarber
Copy link
Contributor

@kostyafarberkostyafarber commentedSep 27, 2022•
edited
Loading

PR Summary

This PR adds gridlines to the last plot in the stylesheets example and adds an annotationax.grid(True) as well as a divider to clearly distinguish between subplots. This addresses#23601

PR Checklist

Tests and Styling

  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

@kostyafarberkostyafarber marked this pull request as draftSeptember 27, 2022 14:45
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@kostyafarberkostyafarber marked this pull request as ready for reviewSeptember 27, 2022 15:08
@kostyafarberkostyafarber changed the titleadd divider and annotation.[DOC]: add divider and annotation. #23601Sep 27, 2022
@kostyafarberkostyafarber changed the title[DOC]: add divider and annotation. #23601[DOC]: add divider and annotation.Sep 27, 2022
kostyafarberand others added2 commitsSeptember 27, 2022 18:09
Co-authored-by: Kinza Raza <kanza.imran@careem.com>
@kostyafarber
Copy link
ContributorAuthor

kostyafarber commentedSep 27, 2022•
edited
Loading

Added@Kinza-Raza as co-author of commit.

@QuLogic
Copy link
Member

Please title the commit/PR correctly. You are adding a grid to the style sheet reference, not a divider and annotation. The latter is an implementation detail of the former.

@kostyafarber
Copy link
ContributorAuthor

No worries will change the PR title.

@kostyafarberkostyafarber changed the title[DOC]: add divider and annotation.[DOC]: adding a grid to the style sheet reference.Sep 28, 2022
@kostyafarber
Copy link
ContributorAuthor

@QuLogic changed the PR title.

@kostyafarber
Copy link
ContributorAuthor

@jklymak let me know if I need to do anything else. Thanks!

Co-authored-by: Jody Klymak <jklymak@gmail.com>
Co-authored-by: Jody Klymak <jklymak@gmail.com>
@jklymak
Copy link
Member

Thanks for your work and patience with this@kostyafarber . I think this looks good, and should be helpful for folks curious about what happens if they turn the grid on.

kostyafarber reacted with hooray emoji

@jklymakjklymak merged commitfd5cf5c intomatplotlib:mainOct 1, 2022
@kostyafarberkostyafarber deleted the issue-23601 branchOctober 2, 2022 16:00
@QuLogicQuLogic added this to thev3.7.0 milestoneOct 4, 2022
Tortar pushed a commit to Tortar/matplotlib that referenced this pull requestOct 18, 2022
* add divider and annotation.Co-authored-by: Kinza Raza <kanza.imran@careem.com>* fix flake8* change from annotate to title* Update examples/style_sheets/style_sheets_reference.pyCo-authored-by: Jody Klymak <jklymak@gmail.com>* Update examples/style_sheets/style_sheets_reference.pyCo-authored-by: Jody Klymak <jklymak@gmail.com>Co-authored-by: Kinza Raza <kanza.imran@careem.com>Co-authored-by: Jody Klymak <jklymak@gmail.com>
melissawm pushed a commit to melissawm/matplotlib that referenced this pull requestDec 19, 2022
* add divider and annotation.Co-authored-by: Kinza Raza <kanza.imran@careem.com>* fix flake8* change from annotate to title* Update examples/style_sheets/style_sheets_reference.pyCo-authored-by: Jody Klymak <jklymak@gmail.com>* Update examples/style_sheets/style_sheets_reference.pyCo-authored-by: Jody Klymak <jklymak@gmail.com>Co-authored-by: Kinza Raza <kanza.imran@careem.com>Co-authored-by: Jody Klymak <jklymak@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

3 participants
@kostyafarber@QuLogic@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp