Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

updated gtk backend#24015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
mablue wants to merge1 commit intomatplotlib:mainfrommablue:main
Closed

updated gtk backend#24015

mablue wants to merge1 commit intomatplotlib:mainfrommablue:main

Conversation

mablue
Copy link

@mabluemablue commentedSep 27, 2022•
edited
Loading

for fixing this error:

  File "/home/mab/.local/lib/python3.10/site-packages/matplotlib/backends/_backend_gtk.py", line 236, in resize    toolbar_size = self.toolbar.size_request()AttributeError: 'NavigationToolbar2GTK4' object has no attribute 'size_request'. Did you mean: 'get_size_request'?

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

for fixing this error:```  File "/home/mab/.local/lib/python3.10/site-packages/matplotlib/backends/_backend_gtk.py", line 236, in resize    toolbar_size = self.toolbar.size_request()AttributeError: 'NavigationToolbar2GTK4' object has no attribute 'size_request'. Did you mean: 'get_size_request'?```
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@QuLogic
Copy link
Member

I see that this does fix the crash ofFigure.set_size_inches on GTK4, but it doesn't seem correct. In GTK3,size_request() returned the height of the toolbar as 42, but usingget_size_request(), it returns -1. And GTK4 also returns -1.

QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestSep 29, 2022
Using the same method as __init__ to avoid the deprecated-in-GTK3 andremoved-in-GTK4 API.Closesmatplotlib#24015
@QuLogic
Copy link
Member

Thank you for your PR@mablue; sorry it did not get merged. But I believe we did manage to fix the issue you were seeing.

@mablue
Copy link
Author

Ok thank you too 😑🥲🤣

@tacaswelltacaswell added this to theunassigned milestoneSep 30, 2022
melissawm pushed a commit to melissawm/matplotlib that referenced this pull requestDec 19, 2022
Using the same method as __init__ to avoid the deprecated-in-GTK3 andremoved-in-GTK4 API.Closesmatplotlib#24015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@mablue@QuLogic@tacaswell@oscargus
[8]ページ先頭
©2009-2025 Movatter.jp