Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix wording and links lifecycle tutorial#24003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 4 commits intomatplotlib:mainfromoscargus:tutorialfix
Sep 26, 2022

Conversation

oscargus
Copy link
Member

@oscargusoscargus commentedSep 25, 2022•
edited
Loading

PR Summary

There was an incorrect sentence that needed rewording. Links added for easier navigation. Add a ,. Replace 1 with one.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Co-authored-by: hannah <story645@gmail.com>
@story645story645 added this to thev3.6-doc milestoneSep 25, 2022
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@oscargus
Copy link
MemberAuthor

Please squash-merge...

@timhoffmtimhoffm merged commitd226954 intomatplotlib:mainSep 26, 2022
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 d226954190e4d3299de4b600af0c19763a41edee
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24003: Fix wording and links lifecycle tutorial'
  1. Push to a named branch:
git push YOURFORK v3.6.x:auto-backport-of-pr-24003-on-v3.6.x
  1. Create a PR against branch v3.6.x, I would have named this PR:

"Backport PR#24003 on branch v3.6.x (Fix wording and links lifecycle tutorial)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.0-docgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 d226954190e4d3299de4b600af0c19763a41edee
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24003: Fix wording and links lifecycle tutorial'
  1. Push to a named branch:
git push YOURFORK v3.6.0-doc:auto-backport-of-pr-24003-on-v3.6.0-doc
  1. Create a PR against branch v3.6.0-doc, I would have named this PR:

"Backport PR#24003 on branch v3.6.0-doc (Fix wording and links lifecycle tutorial)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@oscargusoscargus deleted the tutorialfix branchSeptember 28, 2022 12:04
rcomer pushed a commit to rcomer/matplotlib that referenced this pull requestDec 10, 2022
Manual backport due to conflict from one-line change in this file atmatplotlib#23974.Co-authored-by: hannah <story645@gmail.com>Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@rcomer
Copy link
Member

@meeseeksdev backport to v3.6.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 10, 2022
oscargus added a commit that referenced this pull requestDec 10, 2022
Backport PR#24003 on branch v3.6.2-doc: Fix wording and links lifecycle tutorial
oscargus added a commit that referenced this pull requestDec 10, 2022
…003-on-v3.6.xBackport PR#24003 on branch v3.6.x (Fix wording and links lifecycle tutorial)
melissawm pushed a commit to melissawm/matplotlib that referenced this pull requestDec 19, 2022
* Fix wording and links lifecycle tutorial* Apply suggestions from code reviewCo-authored-by: hannah <story645@gmail.com>* Update tutorials/introductory/lifecycle.pyCo-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>* Update tutorials/introductory/lifecycle.pyCo-authored-by: hannah <story645@gmail.com>Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@story645story645story645 approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6-doc
Development

Successfully merging this pull request may close these issues.

4 participants
@oscargus@rcomer@story645@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp