Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix issue with empty line in ps backend#23964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
4aef735 to0c53446CompareApproving your PR is easier than adding a test to mine :) |
| # append the last entry | ||
| stream.append(curr_stream) | ||
| # append the last entry if exists | ||
| if curr_stream: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
On consideration, I think the looser check here is better than what I had because I suspect other falsy things (like empty lists) would also break the consumer code.
| figure = Figure() | ||
| ax = figure.add_subplot(111) | ||
| ax.set_title('\nLower title') | ||
| ax.annotate(text='\nLower label', xy=(0, 0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would a figtext (fig.text(...), no axes at all) be enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is. I've changed it.
Updated the test and seems to have lost the co-authorship from@tacaswell ... Not sure what you changed, but Ithink that it should be included here (since I pulled the PR to another computer before updating the test). |
You can click the commit links on the 'force-pushed' annotation line here. Looks like just a rebase to me. |
…964-on-v3.6.xBackport PR#23964 on branch v3.6.x (Fix issue with empty line in ps backend)
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Closes#23954
(Identical to#23910 which I forgot existed. This has a test though...)
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).