Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: Display "dev" instead of "devdocs" in the version switcher#23949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:mainfromtimhoffm:version-switcher-dev
Sep 19, 2022

Conversation

timhoffm
Copy link
Member

@timhoffmtimhoffm commentedSep 19, 2022•
edited
Loading

This changesimage to only show "dev".

While the url is devdocs historically, and I'm not going to change this, the displayed names should be "stable" and "dev". This has the added advantage that dev takes a little less space in the menubar, and thus wrapping occurs slightly later.

story645 reacted with thumbs up emoji
While the url is devdocs historically, and I'm not going tochange this, the displayed names should be "stable" and "dev".This has the added advantage that dev takes a little less spacein the menubar, and thus wrapping occurs slightly later.
@timhoffmtimhoffm added this to thev3.6-doc milestoneSep 19, 2022
Copy link
Member

@story645story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No idea if this needs 1 or 2 to merge

@jklymakjklymak merged commitb5fa310 intomatplotlib:mainSep 19, 2022
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 b5fa31067e8e67e308b373285a68c44e9ca5efa8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #23949: DOC: Display "dev" instead of "devdocs" in the version switcher'
  1. Push to a named branch:
git push YOURFORK v3.6.x:auto-backport-of-pr-23949-on-v3.6.x
  1. Create a PR against branch v3.6.x, I would have named this PR:

"Backport PR#23949 on branch v3.6.x (DOC: Display "dev" instead of "devdocs" in the version switcher)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.0-docgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 b5fa31067e8e67e308b373285a68c44e9ca5efa8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #23949: DOC: Display "dev" instead of "devdocs" in the version switcher'
  1. Push to a named branch:
git push YOURFORK v3.6.0-doc:auto-backport-of-pr-23949-on-v3.6.0-doc
  1. Create a PR against branch v3.6.0-doc, I would have named this PR:

"Backport PR#23949 on branch v3.6.0-doc (DOC: Display "dev" instead of "devdocs" in the version switcher)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

QuLogic pushed a commit that referenced this pull requestSep 19, 2022
DOC: Display "dev" instead of "devdocs" in the version switcher(cherry picked from commitb5fa310)
@QuLogic
Copy link
Member

Backported in#23942.

@QuLogicQuLogic modified the milestones:v3.6-doc,v3.6.1Sep 19, 2022
@timhoffmtimhoffm deleted the version-switcher-dev branchSeptember 19, 2022 21:26
melissawm pushed a commit to melissawm/matplotlib that referenced this pull requestDec 19, 2022
DOC: Display "dev" instead of "devdocs" in the version switcher(cherry picked from commitb5fa310)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@story645story645story645 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.

4 participants
@timhoffm@QuLogic@story645@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp