Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix building on MINGW#23947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 2 commits intomatplotlib:mainfromMehdiChinoune:fix-mingw
Sep 19, 2022
Merged

Fix building on MINGW#23947

QuLogic merged 2 commits intomatplotlib:mainfromMehdiChinoune:fix-mingw
Sep 19, 2022

Conversation

MehdiChinoune
Copy link
Contributor

PR Summary

Fix building matplotlib on MINGW. Recent changes ine1fcc90 broke it.

Fixes#23943

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@anntzer
Copy link
Contributor

Seems reasonable now that we require C++11 anyways. Just a minor nit.

@anntzeranntzer added this to thev3.6.1 milestoneSep 19, 2022
Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems reasonable.

@QuLogicQuLogic merged commit68e5ff9 intomatplotlib:mainSep 19, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 19, 2022
@MehdiChinouneMehdiChinoune deleted the fix-mingw branchSeptember 19, 2022 20:44
QuLogic added a commit that referenced this pull requestSep 20, 2022
…947-on-v3.6.xBackport PR#23947 on branch v3.6.x (Fix building on MINGW)
@tacaswell
Copy link
Member

Thank you for this fix and congratulations on your first merged Matplotilb PR@MehdiChinoune 🎉

Hopefully we will hear from you again!

@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicQuLogic approved these changes

@anntzeranntzeranntzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.

[Bug]: Couldn't build matplotlib 3.6.0 with both Clang-15 and GCC-12
4 participants
@MehdiChinoune@anntzer@tacaswell@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp