Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: use process_event in dpi changes on macosx backend#23925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromgreglucas:macosx-resize-event
Sep 18, 2022

Conversation

greglucas
Copy link
Contributor

PR Summary

Avoidsresize_event() deprecation notices that stem from switching dpis or starting with HiDPI. Likely missed while rebasing PR#16931, I tried looking for other potentially deprecated*_event()s hidden in the macos code and I didn't find any at a cursory glance.

closes#23921

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (andpytest passes).
  • [N/A] IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Avoids resize_event deprecation notices.
@greglucasgreglucas added this to thev3.6.1 milestoneSep 17, 2022
Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This works on my machine. Thanks!

Note I didn't test on alternate dpi displays...

@greglucas
Copy link
ContributorAuthor

I did swap the figure between different DPI monitors and it worked as expected without deprecation warnings.

@tacaswelltacaswell merged commit21493c5 intomatplotlib:mainSep 18, 2022
@tacaswell
Copy link
Member

Also verified it worked locally.

Thank you for the very fast turn around@greglucas !

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 18, 2022
oscargus added a commit that referenced this pull requestSep 18, 2022
…925-on-v3.6.xBackport PR#23925 on branch v3.6.x (FIX: use process_event in dpi changes on macosx backend)
@Emir-ATPC
Copy link

Hello I don't understand how to use this fix to avoid the error

@greglucasgreglucas deleted the macosx-resize-event branchMarch 21, 2024 01:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.

[Bug]: resize_event deprecation warnings when creating figure on macOS with version 3.6.0
4 participants
@greglucas@tacaswell@Emir-ATPC@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp