Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: remove dead "Show Source" links#23919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
doc/conf.py Outdated
"navbar_end": ["theme-switcher", "version-switcher", "mpl_icon_links"], | ||
"page_sidebar_items": [ | ||
"page-toc.html", | ||
"searchbox.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We don't want thesearchbox
"searchbox.html", |
Unsure if we neededit-this-page. At least in the the CI-built docs it does not seem to have an effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, I didn't carefully check the built docs - fixed.
Although I don't quite understand whysearchbox andedit-this-page are not shown in the current docs:mpl-sphinx-theme
inherits frompydata-sphinx-theme
which by defaultincludes bothsearchbox andedit-this-page in the sidebar. Where is this excluded/overridden intheme.conf
orconf.py
?
Remove dead links to source code as _source directory was intentionallyremoved in the circle config config.yml because store_artifcats uploadsfiles one by one which takes an inordinate amount of time.
…919-on-v3.6.xBackport PR#23919 on branch v3.6.x (DOC: remove dead "Show Source" links)
…919-on-v3.6.0-docBackport PR#23919 on branch v3.6.0-doc (DOC: remove dead "Show Source" links)
PR Summary
Remove dead links to source code as _source directory was intentionally removed in the circle config config.yml because store_artifcats uploads files one by one which takes an inordinate amount of time.
Closes#23876 .
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).