Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: remove dead "Show Source" links#23919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromStefRe:DOC/source_link
Sep 18, 2022

Conversation

StefRe
Copy link
Contributor

PR Summary

Remove dead links to source code as _source directory was intentionally removed in the circle config config.yml because store_artifcats uploads files one by one which takes an inordinate amount of time.

Closes#23876 .

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@StefReStefRe marked this pull request as draftSeptember 17, 2022 09:40
@StefReStefRe marked this pull request as ready for reviewSeptember 17, 2022 10:19
doc/conf.py Outdated
"navbar_end": ["theme-switcher", "version-switcher", "mpl_icon_links"],
"page_sidebar_items": [
"page-toc.html",
"searchbox.html",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We don't want thesearchbox

Suggested change
"searchbox.html",

Unsure if we neededit-this-page. At least in the the CI-built docs it does not seem to have an effect.

Copy link
ContributorAuthor

@StefReStefReSep 17, 2022
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry, I didn't carefully check the built docs - fixed.
Although I don't quite understand whysearchbox andedit-this-page are not shown in the current docs:mpl-sphinx-theme inherits frompydata-sphinx-theme which by defaultincludes bothsearchbox andedit-this-page in the sidebar. Where is this excluded/overridden intheme.conf orconf.py?

Remove dead links to source code as _source directory was intentionallyremoved in the circle config config.yml because store_artifcats uploadsfiles one by one which takes an inordinate amount of time.
@StefReStefRe changed the titleDOC: remove dead soure code linksDOC: remove dead "Show Source" linksSep 17, 2022
@tacaswelltacaswell added this to thev3.6-doc milestoneSep 17, 2022
@timhoffmtimhoffm added the Documentation: websitelayout/behavior/styling changes labelSep 18, 2022
@timhoffmtimhoffm merged commitb637f41 intomatplotlib:mainSep 18, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 18, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 18, 2022
@StefReStefRe deleted the DOC/source_link branchSeptember 19, 2022 05:06
timhoffm added a commit that referenced this pull requestSep 19, 2022
…919-on-v3.6.xBackport PR#23919 on branch v3.6.x (DOC: remove dead "Show Source" links)
timhoffm added a commit that referenced this pull requestSep 19, 2022
…919-on-v3.6.0-docBackport PR#23919 on branch v3.6.0-doc (DOC: remove dead "Show Source" links)
melissawm pushed a commit to melissawm/matplotlib that referenced this pull requestDec 19, 2022
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
@timhoffmtimhoffm mentioned this pull requestMar 5, 2024
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Documentation: websitelayout/behavior/styling changes
Projects
None yet
Milestone
v3.6-doc
Development

Successfully merging this pull request may close these issues.

[Doc]: Missing source files
3 participants
@StefRe@timhoffm@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp