Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: only expect FigureCanvas on backend module if using new style#23912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is to un-break pycharm's backend_interaggClosesmatplotlib#23911
anntzer approved these changesSep 16, 2022
oscargus approved these changesSep 17, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 17, 2022
…d module if using new style
ice1000 commentedSep 22, 2022
Is this released? |
No, this will be in 3.6.1 when it is relesaed. |
ice1000 commentedSep 23, 2022
Looking forward! |
QuLogic added a commit that referenced this pull requestSep 23, 2022
…912-on-v3.6.xBackport PR#23912 on branch v3.6.x (FIX: only expect FigureCanvas on backend module if using new style)
Thanks for moving so quickly on this@tacaswell! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is to un-break pycharm's backend_interagg
Closes#23911
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).I'm not sure the best way to test this, I guess we need to make a minimal backend that does not have FigureCanvas and try push it through the machinery? Is it worth the effort?