Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

added a reversing section to colormap reference#23904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromstory645:color
Sep 24, 2022

Conversation

@story645
Copy link
Member

@story645story645 commentedSep 15, 2022•
edited
Loading

PR Summary

changed the note about reversing a colormap into a section of the colormap reference 'cause it was kind of buried in the preamble

image

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@story645
Copy link
MemberAuthor

story645 commentedSep 19, 2022•
edited
Loading

it's very possibly on the verbose side now, but changed the reversed section in the reference to show viridis, cleaned up language, and linked out to a new reversing section in the colormap tutorial that has acmap.reversed() example

@story645story645force-pushed thecolor branch 2 times, most recently frome6b44f6 to46af8cbCompareSeptember 19, 2022 02:31
@story645story645force-pushed thecolor branch 2 times, most recently from0d7e51e to284d9e2CompareSeptember 20, 2022 00:28
@story645story645force-pushed thecolor branch 2 times, most recently fromb238db5 toce3e284CompareSeptember 20, 2022 03:50
reversing + registering section to colormap tutorialremoved parent notation from `reversed` methods b/c no heirarchyCo-authored-by: RutgerK <2157033+RutgerK@users.noreply.github.com>Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>Co-authored-by: Jody Klymak <jklymak@gmail.com>Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
@timhoffmtimhoffm merged commit3637134 intomatplotlib:mainSep 24, 2022
@QuLogicQuLogic added this to thev3.7.0 milestoneSep 24, 2022
@story645
Copy link
MemberAuthor

story645 commentedSep 25, 2022•
edited
Loading

@QuLogic these are all doc changes so shouldn't the milestone be v3.6.1/why is it 3.7.0?

@jklymakjklymak modified the milestones:v3.7.0,v3.6-docSep 25, 2022
@timhoffm
Copy link
Member

timhoffm commentedSep 25, 2022•
edited
Loading

@meeseeksdev backport to v3.6.x

This is not v3.6-doc because it contains changes to files inlib (that it‘s only docstrings there does not matter).

@timhoffmtimhoffm modified the milestones:v3.6-doc,v3.6.1Sep 25, 2022
@QuLogic
Copy link
Member

@QuLogic these are all doc changes so shouldn't the milestone be v3.6.1/why is it 3.7.0?

I only document what has occurred in merged PRs.

@story645
Copy link
MemberAuthor

I only document what has occurred in merged PRs.

So you set the milestone as 3.7.0 b/c it was merged into main?, and this would have to be backported and then changed to 3.6.1?

@story645
Copy link
MemberAuthor

@meeseeksdev backport to v3.6.1

@lumberbot-app
Copy link

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@story645
Copy link
MemberAuthor

story645 commentedSep 28, 2022•
edited
Loading

oops, 3.6.1 doesn't exist yet 🤦‍♀️

@timhoffm
Copy link
Member

@meeseeksdev backport to v3.6.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 28, 2022
timhoffm added a commit that referenced this pull requestSep 28, 2022
…904-on-v3.6.xBackport PR#23904 on branch v3.6.x (added a reversing section to colormap reference)
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
@story645story645 deleted the color branchOctober 12, 2023 16:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tacaswelltacaswelltacaswell left review comments

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

v3.6.1

Development

Successfully merging this pull request may close these issues.

5 participants

@story645@timhoffm@QuLogic@tacaswell@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp