Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Pillow compatibility in example#23881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
anntzer merged 1 commit intomatplotlib:mainfromoscargus:pillowversionhandling
Sep 15, 2022

Conversation

oscargus
Copy link
Member

PR Summary

Shouldfix#23855 (comment)

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@oscargusoscargus added this to thev3.6.0 milestoneSep 13, 2022
@oscargusoscargus marked this pull request as ready for reviewSeptember 13, 2022 08:33
@anntzer
Copy link
Contributor

Instead of resampling down the stinkbug image down to 64x64 via pillow code (which is a bit distracting for the tutorial, especially if you start having version gating like here), perhaps simpler would be to just crop down to its central region? e.g. img[175:225, 225:275] seems reasonable. (Obviously the surrounding text needs adjusting too.)

@oscargusoscargus mentioned this pull requestSep 13, 2022
2 tasks
@oscargus
Copy link
MemberAuthor

To be fully honest, I didn't read another line of the code except for the problematic one...

Doing that, do we actually need to specify the resampling scheme? I mean, it is really a Pillow-function that we are using, so maybe it is not that important? (Default is bicubic.)

(Btw, we also provide an, untested, thumbnail function, although that reads the file, possibly pops it up, and then saves it, as well as returning a Figure.)

@anntzer
Copy link
Contributor

I didn't really pay attention to the context either.

@oscargus
Copy link
MemberAuthor

I changed it to not specify resampling scheme (as that sort of makes sense as well and my previous approach was wrong).

@oscargus
Copy link
MemberAuthor

oscargus commentedSep 13, 2022
edited
Loading

It seems like thepikepdf install is suddenly failing...

6.0.0 was released yesterday with a 6.0.0.post1 release two hours ago. Maybe it is just to wait for wheels to be published?

@oscargus
Copy link
MemberAuthor

oscargus commentedSep 13, 2022
edited
Loading

Windows and OSX support is currently blocked:pikepdf/pikepdf#390

Pin version (except for Linux)?

@tacaswell
Copy link
Member

Pin version (except for Linux)?

Yes

@oscargusoscargus mentioned this pull requestSep 15, 2022
6 tasks
@anntzeranntzer reopened thisSep 15, 2022
@anntzeranntzer merged commit7007c5c intomatplotlib:mainSep 15, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 15, 2022
tacaswell added a commit that referenced this pull requestSep 15, 2022
…881-on-v3.6.xBackport PR#23881 on branch v3.6.x (Fix Pillow compatibility in example)
@oscargusoscargus deleted the pillowversionhandling branchSeptember 16, 2022 12:00
melissawm pushed a commit to melissawm/matplotlib that referenced this pull requestDec 19, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

3 participants
@oscargus@anntzer@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp