Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add tests for mpl_toolkit anchored artists#23863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromoscargus:testanchoredartists
Mar 13, 2023

Conversation

oscargus
Copy link
Member

@oscargusoscargus commentedSep 11, 2022
edited
Loading

PR Summary

Tests for previously untested anchored artists.

Includes the fix in#23862 so if this is merged before that, no need for that. But since that should go in 3.6 and this doesn't have to...

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@jklymak
Copy link
Member

We should probably talk about where all these tests are going? mpl_toolkits has, in the past, been discussed as under-tested and under-maintained. If we want to maintain it, why not move into the main library?

@oscargus
Copy link
MemberAuthor

I have not really understood the role of mpl_toolkits. Is it correct that it is possible to "install" other packages under mpl_toolkits and that some do?`

Primarily just trying to increase coverage and learn a bit more of the code base... (And sometimes, untested code actually turns out to be incorrect, like in this case.)

But one could for sure, I guess, claim that for 4.0 one moves the useful parts of it to the main library?

@jklymak
Copy link
Member

jklymak commentedSep 11, 2022
edited
Loading

💯 your work here has been great and,if we plan to keep these routines around, is well overdue. But if the plan is to obsolete a fair bit of this, then I didn't want you to feel you had wasted effort.

It would be great to revisit this on a call soon. I guess id recommend that if you find parts of the tool kit useful, consider if there are straightforward ways to bring into the main library. For instance we did that with inset_axes a couple of years ago, and 3.6 will have layout="compressed" which is meant to do the same things as image_grid.

@oscargus
Copy link
MemberAuthor

I do not really have that much of a threshold for doing this. Something I play around with when I lack energy for proper things... It will probably take some time to deprecate etc anyway.

@jklymak
Copy link
Member

Yes but if we codify the behaviour with tests, it becomes even harder to change and or deprecate.

@oscargus
Copy link
MemberAuthor

oscargus commentedSep 12, 2022 via email
edited
Loading

Another way to see it is that then we know that we change the behavior...(All these exists in tutorials/examples. I have more or less copied themfrom there and only changed a bit to trigger parts of the code.)But let's talk about it on Thursday(?).(There is code that has completely broke in some examples as there's beenno tests for it.)
story645 reacted with thumbs up emoji

@QuLogicQuLogic added this to thev3.7.2 milestoneMar 8, 2023
@ksundenksunden merged commitbc28efb intomatplotlib:mainMar 13, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 13, 2023
rcomer added a commit that referenced this pull requestMar 13, 2023
…863-on-v3.7.xBackport PR#23863 on branch v3.7.x (Add tests for mpl_toolkit anchored artists)
@oscargusoscargus deleted the testanchoredartists branchMarch 13, 2023 22:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.7.2
Development

Successfully merging this pull request may close these issues.

4 participants
@oscargus@jklymak@QuLogic@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp