  FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpheklt6mf.build-lib/matplotlib/mpl-data/matplotlibrc'              If you are seeing this warning it is very likely that a setuptools              plugin or customization overrides the `build_py` command, without              tacking into consideration how editable installs run build steps              starting from v64.0.0.              Plugin authors and developers relying on custom build steps are encouraged              to update their `build_py` implementation considering the information in              https://setuptools.pypa.io/en/latest/userguide/extension.html              about editable installs.              For the time being `setuptools` will silence this error and ignore              the faulty command, but this behaviour will change in future versions.

~~Lots of:~~

  /tmp/pip-build-env-7a9fvqdh/overlay/lib/python3.10/site-packages/setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning:     Installing 'matplotlib.tests.baseline_images.test_polar' as data is deprecated, please list it in `packages`.      !!      ############################      # Package would be ignored #      ############################      Python recognizes 'matplotlib.tests.baseline_images.test_polar' as an importable package,      but it is not listed in the `packages` configuration of setuptools.      'matplotlib.tests.baseline_images.test_polar' has been automatically added to the distribution only      because it may contain data files, but this behavior is likely to change      in future versions of setuptools (and therefore is considered deprecated).      Please make sure that 'matplotlib.tests.baseline_images.test_polar' is included as a package by using      the `packages` configuration field or the proper discovery methods      (for example by using `find_namespace_packages(...)`/`find_namespace:`      instead of `find_packages(...)`/`find:`).      You can read more about "package discovery" and "data files" on setuptools      documentation page.

PR Checklist

Tests and Styling

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

New features are documented, with examples if plot related.
New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

oscargus force-pushed thepyproject branch 2 times, most recently from3fe5d58 to9b87d69Compare

September 8, 2022 19:44

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should beoldest-supported-numpy, seehttps://github.com/scipy/oldest-supported-numpy

The problem is that if you put a floor here, then when the background env gets made it will pull the newest version of numpy it can find. Numpy promises that things complied with old numpy will work with new numpy at runmtime, but they do not promise that things compiled with new numpy will work with old numpy at runtime.

Suggested change

	requires = ["setuptools>=45","setuptools_scm[toml]>=7","wheel","certifi>=2020.06.20","numpy>=1.19"]
	requires = ["setuptools>=45","setuptools_scm[toml]>=7","wheel","certifi>=2020.06.20","oldest-supported-numpy"]

Copy link

MemberAuthor

oscargusSep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Now it seems like the following happens:

  xarray 2022.6.0 requires numpy>=1.19, but you have numpy 1.17.3 which is incompatible.  pandas 1.4.4 requires numpy>=1.18.5; platform_machine != "aarch64" and platform_machine != "arm64" and python_version < "3.10", but you have numpy 1.17.3 which is incompatible.

tacaswell added this to thev3.7.0 milestone

Sep 12, 2022

oscargus force-pushed thepyproject branch 2 times, most recently from60890cd to8ada724Compare

September 15, 2022 20:01

Copy link

Member

ianthomas23 commentedSep 20, 2022

In the long run, when all the C/C++ extensions are wrapped usingpybind11 we won't need anynumpy in the[build-system] requires section. To make headway here I think it needs to be "numpy==1.19".

We might have to be careful with theminver test in CI. Because of the build isolationmpl will build against thebuild-system requires rather than the preinstalledminver packages. So if we don't modify the CI then theminimum-versions test will test but not build against the minimum versions whereas now it both builds and tests against them. This might be fine; if not we will probably need topip install --no-build-isolation -ve . (or similar) for the minimum versions test only.

oscargus force-pushed thepyproject branch from8ada724 to344dfb1Compare

October 4, 2022 12:40

Copy link

MemberAuthor

oscargus commentedOct 4, 2022

New error in some builds:

          File "numpy/core/setup.py", line 655, in get_mathlib_info            raise RuntimeError("Broken toolchain: cannot link a simple C program")        RuntimeError: Broken toolchain: cannot link a simple C program

ianthomas23 mentioned this pull request

Oct 6, 2022

Simplest pyproject.toml containing build-system only#24102

Merged

Copy link

Member

ianthomas23 commentedOct 16, 2022

It is probably worth rebasing this onmain to see where we've got to.

story645 previously requested changes

Oct 16, 2022

View reviewed changes

pyproject.toml OutdatedShow resolvedHide resolved

oscargus force-pushed thepyproject branch from344dfb1 to4fa96faCompare

October 16, 2022 19:27

oscargus added the CI: Run cibuildwheelRun wheel building tests on a PR label

Oct 16, 2022

oscargus force-pushed thepyproject branch 2 times, most recently from17800b5 tof650809Compare

October 16, 2022 19:37

story645 dismissed theirstale review

October 16, 2022 19:44

Fixed

Copy link

MemberAuthor

oscargus commentedOct 16, 2022

Looks surprisingly promising. Wouldn't trust it even if everything happens to pass though (hasn't happened yet).

For example, I do not really know how to deal with the namespace package thing (not what it actually is).

oscargus commented

Oct 16, 2022

View reviewed changes

pyproject.toml

		"pillow>=6.2.0",
		"pyparsing>=2.2.1",
		"python-dateutil>=2.7",
		"setuptools_scm>=7.0"

Copy link

MemberAuthor

oscargusOct 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should be conditional, but I have not found any info how to do this dynamically.

Copy link

Member

ianthomas23Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think it is needed at all as it is in the[build-system] requires section. It is needed by anyone who uses--no-build-isolation in theirpip install ., but in that situation they will need to have preinstalled all of the[build-system] requires packages to proceed.

Although I might be missing some other use ofsetuptools_scm in testing or somewhere else?

Copy link

MemberAuthor

oscargusOct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It was added as someone had problems running tests in a particular setup(?).

Without it, this breaks in the tests:

matplotlib/lib/matplotlib/__init__.py

Lines 171 to 180 in007c4c1

	if ((root/".matplotlib-repo").exists()
	and (root/".git").exists()
	andnot (root/".git/shallow").exists()):
	importsetuptools_scm
	returnsetuptools_scm.get_version(
	root=root,
	version_scheme="release-branch-semver",
	local_scheme="node-and-date",
	fallback_version=_version.version,
	)

although it indeed is not really required for a user install.

Copy link

Member

ianthomas23Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I see now. So it shouldn't be in thedependencies section of thepyproject.toml as then wheel users will be forced to have it which means it should be in one of the requirements files instead, perhapsrequirements/testing/all.txt?

Eventually I would expect the requirements files to be replaced with[project.optional-dependencies] sections in thepyproject.toml, but that is not necessary yet.

Copy link

MemberAuthor

oscargus commentedOct 16, 2022

Wheels are 37 MB. Probably as the test images are included...

ianthomas23 reviewed

Oct 17, 2022

View reviewed changes

setup.py OutdatedShow resolvedHide resolved

oscargus force-pushed thepyproject branch 2 times, most recently frome921399 to3d8c9c8Compare

October 19, 2022 12:54

github-actionsbot added the status: needs rebase label

Oct 19, 2022

tacaswell modified the milestones:v3.7.0,v3.8.0

Dec 15, 2022

Copy link

Member

tacaswell commentedDec 15, 2022

Push this to mpl 3.8 to avoid any last-minute packaging issues for mpl 3.7.

Copy link

Member

ianthomas23 commentedFeb 13, 2023

@oscargus I've experimented with this locally and I think I have made some progress. If I add this new section to thepyproject.toml:

[tool.setuptools]include-package-data = false

then the test images are excluded from the wheel. That might be excluding too much, so if you remove that section (include-package-data istrue by default) and add this one instead:

[tool.setuptools.exclude-package-data]"*" = ["*.png", "*.svg"]

then only the PNGs and SVGs are excluded. That still might be excluding too many files, but it is a start.

oscargus force-pushed thepyproject branch from3d8c9c8 tof36c822Compare

February 16, 2023 20:33

github-actionsbot removed the status: needs rebase label

Feb 16, 2023

Copy link

MemberAuthor

oscargus commentedFeb 16, 2023

Thanks@ianthomas23 ! I've updated it and now I think I know how to check the possible problems as well.

oscargus marked this pull request as ready for review

February 16, 2023 20:40

oscargus force-pushed thepyproject branch 2 times, most recently fromcd84117 to8b2df24Compare

February 16, 2023 20:49

oscargus marked this pull request as draft

February 16, 2023 20:50

oscargus removed the CI: Run cibuildwheelRun wheel building tests on a PR label

Feb 16, 2023

oscargus force-pushed thepyproject branch from8b2df24 toe40edd8Compare

February 16, 2023 21:00

oscargus added the CI: Run cibuildwheelRun wheel building tests on a PR label

Feb 16, 2023

Start transitioning to pyproject.toml

6c877d7

oscargus force-pushed thepyproject branch frome40edd8 to6c877d7Compare

February 17, 2023 07:15

github-actionsbot added the status: needs rebase label

Feb 22, 2023

Copy link

Member

QuLogic commentedJun 12, 2023

We discussed this last week on call; we think it makes sense to start having some kind ofdev extra on which we can add dependencies likesetuptools-scm. I also think that some of the limitations that arise from purely-declarative will be solved in the Meson port. Since we already need to move topyproject.toml in order to complete the Meson port, I'm thinking of taking this over and rolling it into that PR.

Copy link

MemberAuthor

oscargus commentedJun 15, 2023

Feel free to do so! I was trying to learn, and I have learnt, but not sure if my knowledge will be enough to finish it (although the dev-section etc is quite straightforward...).