Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove useless semicolons in "Introductory / Basic Usage" tutorial#23796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromgustavi:gustavi-patch-1
Oct 21, 2022
Merged

Remove useless semicolons in "Introductory / Basic Usage" tutorial#23796

timhoffm merged 1 commit intomatplotlib:mainfromgustavi:gustavi-patch-1
Oct 21, 2022

Conversation

gustavi
Copy link
Contributor

PR Summary

Remove useless semicolons in tutorialhttps://matplotlib.org/stable/tutorials/introductory/usage.html#sphx-glr-tutorials-introductory-usage-py.

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (andpytest passes).
  • [n/a] IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@tacaswell

This comment was marked as outdated.

@tacaswell
Copy link
Member

On second thought, that output is also inhttps://matplotlib.org/3.6.0/tutorials/introductory/quick_start.html#a-simple-example which is counter to what I expected so maybe they are useless...

There is clearly something I do not understand about sphinx-gallery here.

@QuLogic
Copy link
Member

Yes,@jklymak added these on purpose to suppress the output#21794, but they didn't seem to have worked.

@timhoffm
Copy link
Member

timhoffm commentedSep 2, 2022
edited
Loading

IMHO we should to discuss with sphinx-gallery to make showing outputs configurable. Even if the semicolon worked it can be a little confusing for users not familiar with it.

Ideally that option could be configured on a global/file/block basis and be overridden by the more specific ones; i.e. global=off, this block=on.

@StefRe
Copy link
Contributor

StefRe commentedSep 2, 2022
edited
Loading

You can now configurecapture_repron file-by-file basis, seesphinx-gallery/sphinx-gallery#891. It just didn't have the time to apply this to the matplotlib docs.
So the plan is to globally turn off capturing and revert this in the couple of examples where it's needed, i.e. it basically just requires to go through the examples and tutorials and set the capturing where needed.

timhoffm reacted with thumbs up emoji

@StefRe
Copy link
Contributor

There is clearly something I do not understand about sphinx-gallery here.

@tacaswell : as I explained insphinx-gallery/sphinx-gallery#891: putting a semicolon after the last expression doesn't work here as the code is first compiled into an AST and then the last expression is taken from the tree where the semicolon as code delimiter isn't present, seecode.

@timhoffm
Copy link
Member

timhoffm commentedSep 24, 2022
edited
Loading

Superseded by#23978 .

@gustavi thank you for your effort, even though we found different solution to solve the issue.

gustavi reacted with thumbs up emoji

@StefRe
Copy link
Contributor

@timhoffm in fact the PR is still valid - the semicolons are useless in this case (see#23796 (comment)) and should be removed (along with the corresponding flake ignore)

@timhoffmtimhoffm reopened thisSep 24, 2022
@timhoffm
Copy link
Member

@StefRe thanks for the correction.

@tacaswell
Copy link
Member

"power cycled" to get the azure to re-run

@tacaswelltacaswell added this to thev3.7.0 milestoneOct 20, 2022
@timhoffmtimhoffm merged commitad0a4c0 intomatplotlib:mainOct 21, 2022
@timhoffm
Copy link
Member

Thanks@gustavi, and congratulations on your first contribution to Matplotlib!

gustavi reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

6 participants
@gustavi@tacaswell@QuLogic@timhoffm@StefRe@scottshambaugh

[8]ページ先頭

©2009-2025 Movatter.jp