Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Remove useless semicolons in "Introductory / Basic Usage" tutorial#23796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
This comment was marked as outdated.
This comment was marked as outdated.
tacaswell commentedSep 1, 2022
On second thought, that output is also inhttps://matplotlib.org/3.6.0/tutorials/introductory/quick_start.html#a-simple-example which is counter to what I expected so maybe they are useless... There is clearly something I do not understand about sphinx-gallery here. |
QuLogic commentedSep 1, 2022
timhoffm commentedSep 2, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
IMHO we should to discuss with sphinx-gallery to make showing outputs configurable. Even if the semicolon worked it can be a little confusing for users not familiar with it. Ideally that option could be configured on a global/file/block basis and be overridden by the more specific ones; i.e. global=off, this block=on. |
StefRe commentedSep 2, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
You can now configure |
StefRe commentedSep 10, 2022
@tacaswell : as I explained insphinx-gallery/sphinx-gallery#891: putting a semicolon after the last expression doesn't work here as the code is first compiled into an AST and then the last expression is taken from the tree where the semicolon as code delimiter isn't present, seecode. |
timhoffm commentedSep 24, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
StefRe commentedSep 24, 2022
@timhoffm in fact the PR is still valid - the semicolons are useless in this case (see#23796 (comment)) and should be removed (along with the corresponding flake ignore) |
timhoffm commentedSep 24, 2022
@StefRe thanks for the correction. |
tacaswell commentedOct 20, 2022
"power cycled" to get the azure to re-run |
timhoffm commentedOct 21, 2022
Thanks@gustavi, and congratulations on your first contribution to Matplotlib! |
PR Summary
Remove useless semicolons in tutorialhttps://matplotlib.org/stable/tutorials/introductory/usage.html#sphx-glr-tutorials-introductory-usage-py.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).