Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Use cleaner recursion check in PyQt FigureCanvas' resizeEvent.#23729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
…ureCanvas' resizeEvent.
Thank you@anthepro for this PR and tracking down the underlying problem! Congratulations on your first merged Matplotlib PR 🎉 Hopefully we will hear from you again! |
…729-on-v3.6.xBackport PR#23729 on branch v3.6.x (Use cleaner recursion check in PyQt FigureCanvas' resizeEvent.)
As suggested in issue#22409, using sys._getframe can lead to a memory leak which then causes PyQt to send the wrong event type. This solves the issue by and using a cleaner solution which avoids sys._getframe for determining recursion.