import matplotlib.pyplot as pltplt.rcdefaults()plt.rc('font', family=['cmr10'])plt.rc('mathtext', fontset='cm')plt.rc('axes.formatter', use_mathtext=True)plt.semilogy([-0.03, 0.05], [0.3, 0.05])plt.show()

I felt that having all glyph fixes in the same place would result in cleaner code. This will also be easy to extend if, in the future, we plan to add more glyph substitutions.

PR Checklist

Tests and Styling

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

[N/A] New features are documented, with examples if plot related.
[N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
[N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
[N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

oscargus approved these changes

Aug 22, 2022

View reviewed changes

Copy link

Member

oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One may consider a test. but I cannot really tell what would be the simplest test as a normaltext with `\times' does already work.

Copy link

ContributorAuthor

tfpf commentedAug 22, 2022

I think testing this isn't straightforward, since the missing multiplication sign logs a warning, but doesn't raise a user warning. (Otherwise, something similar to#20235 could be used to detect it.)

One thing I missed:cmr10_cmsy10_substitutions should probably be private; the way it is used seems to be an implementation detail.

Copy link

Contributor

anntzer commentedAug 22, 2022

Perhapshttps://docs.pytest.org/en/7.1.x/how-to/logging.html#caplog-fixture can help.

Copy link

Member

oscargus commentedAug 22, 2022

I was more thinking about testing that the multiplication sign shows up (instead of ¤), rather than the warning thing.

tfpf force-pushed thecmr10_cmsy10_substitutions branch fromba3891d to077ea7cCompare

August 22, 2022 16:35

Copy link

ContributorAuthor

tfpf commentedAug 22, 2022•
edited
Loading

I was more thinking about testing that the multiplication sign shows up (instead of ¤), rather than the warning thing.

I think this would require an image comparison test? I could add it if required.

tfpf commented

Aug 22, 2022

View reviewed changes

lib/matplotlib/tests/test_ticker.pyShow resolvedHide resolved

Copy link

ContributorAuthor

tfpf commentedAug 23, 2022

Strange. How did the code coverage decrease. There are no uncovered lines reported in the diff.

Copy link

Member

oscargus commentedAug 24, 2022

I do not really understand how that test works, but it does fail from time to time, so no worries about it. (Except for maybe people not reviewing as the build "fails" anyway...)