Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Doc]: Document the position parameter in apply_aspect()#23618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromhaziq-khurshid:feature-23583
Aug 14, 2022

Conversation

haziq-khurshid
Copy link
Contributor

PR Summary

This PR documents the position paramter in apply_aspect()
Issue:#23583

PR Checklist

Tests and Styling

  • [N/A ] Has pytest style unit tests (andpytest passes).
  • [ N/A] IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [ N/A] New features are documented, with examples if plot related.
  • [ N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [ N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@haziq-khurshid
Copy link
ContributorAuthor

@tacaswell Kindly close the previous PR:#23617
I couldn't update it because I had deleted the branch used to make that PR.
Apologies for any inconvinience.

@tacaswell
Copy link
Member

In the future when you open a PR please only open it once and then push changes to that branch.

haziq-khurshid reacted with thumbs up emoji

@tacaswelltacaswell added this to thev3.6.0 milestoneAug 14, 2022
@tacaswelltacaswell merged commitecba9d2 intomatplotlib:mainAug 14, 2022
@tacaswell
Copy link
Member

Thank you for you work on this@haziq-khurshid and congratulations on your first merged Matplotlib PR 🎉

Hopefully we will hear from you agian!

@haziq-khurshid
Copy link
ContributorAuthor

Thank you@tacaswell for being helpful.
I'll definitely contribute more often in the future!

tacaswell reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

2 participants
@haziq-khurshid@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp