Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
[Doc]: Document the position parameter in apply_aspect()#23617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@haziq-khurshid Why did you close this? I think the docstring is an improvement, the |
@tacaswell thank you for responding. |
I will reopen this PR for you, please push new commits to this branch. It looks like there are three warnings in the build (which are different than I guessed they would be from glancing at the rst).
The first is due to The next two look to be the same actually issue which is you have put two back ticks before "None" and only one after so the rst parsing is failing. Additionally, I think the "Paremeters" section should goafter the the paragraph you put it above. |
Closing in favor of#23618 I have never seen github driven to this state where two PRs both report they are against the same branch. |
PR Summary
This PR documents the position paramter in apply_aspect()
Issue:#23583
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).