Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: document that appearance is part of our stable API#23607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is a long standing policy (the reference I found is from 2015 and Iremember that being the position when I started to work on Matplotlib in 2012)and is being documented here.This position is consistent with our testing scheme (that strives for pixelidentical renderings across platforms, Python versions, and Matplotlibversions).Changing the default colormap (and the rest of the styling) was the proximalcause of 2.0 not being 1.6 due to this policy.
bc4be15 to3a51e7eComparetimhoffm approved these changesAug 12, 2022
efiring approved these changesAug 12, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 20, 2022
Something went wrong ... Please have a look at my logs. It seems that the branch you are trying to backport to does not exist. |
I self merged this on the strength of the two reviews to get this off the queue. |
QuLogic added a commit that referenced this pull requestOct 21, 2022
…607-on-v3.6.xBackport PR#23607 on branch v3.6.x (DOC: document that appearance is part of our stable API)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a long standing policy (the reference I found is from 2015 and I remember that being the position when I started to work on Matplotlib in 2012) and is being documented here.
This position is consistent with our testing scheme (that strives for pixel identical renderings across platforms, Python versions, and Matplotlib versions).
Changing the default colormap (and the rest of the styling) was the proximal cause of 2.0 not being 1.6 due to this policy.
This PR is not an opportunity to debate if thisshould be the position we take, it documenting what it currently is. If we want to start a discussion about changing the then that must be done in a follow on PR.