Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Change exception types, improve argument checking, and cleanups in mpl_toolkits#23550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 4 commits intomatplotlib:mainfromoscargus:mpltoolkitcleanups
Aug 5, 2022

Conversation

oscargus
Copy link
Member

@oscargusoscargus commentedAug 4, 2022•
edited
Loading

PR Summary

Raise a more exact type.

Better argument checking.

Minor cleanups.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@oscargusoscargusforce-pushed thempltoolkitcleanups branch 2 times, most recently from00be652 toa95cf32CompareAugust 4, 2022 09:44
@oscargusoscargus changed the titleChange exception types and cleanupsChange exception types, improve argument checking, and cleanupsAug 4, 2022
@oscargusoscargus changed the titleChange exception types, improve argument checking, and cleanupsChange exception types, improve argument checking, and cleanups in mpl_toolkitsAug 4, 2022
@oscargusoscargus marked this pull request as ready for reviewAugust 4, 2022 11:53
@@ -48,6 +49,7 @@ def __init__(self, fig, pos, horizontal, vertical,
self._horizontal = horizontal
self._vertical = vertical
self._anchor = anchor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can drop this line now?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Won't some code quality tools complain if it is defined outside of__init__? That was the reason anyway.

@tacaswelltacaswell added this to thev3.6.0 milestoneAug 4, 2022
@QuLogicQuLogic merged commit80d79eb intomatplotlib:mainAug 5, 2022
@oscargusoscargus deleted the mpltoolkitcleanups branchAugust 5, 2022 08:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

4 participants
@oscargus@QuLogic@anntzer@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp