Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add tests for WebAgg using Playwright#23540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
QuLogic wants to merge10 commits intomatplotlib:main
base:main
Choose a base branch
Loading
fromQuLogic:test-webagg

Conversation

QuLogic
Copy link
Member

PR Summary

This may make WebAgg the most tested backend...

I'm not sure what to do about the screenshot test, as I really want to confirm that the figure is sent to the browser, but browsers differ in how they show the resize grip, which causes te comparison to fail.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@timhoffm
Copy link
Member

I'm not sure what to do about the screenshot test, as I really want to confirm that the figure is sent to the browser, but browsers differ in how they show the resize grip, which causes te comparison to fail.

Can you mask the resize grip by drawing a white rectangle on top using imagemagic?

@tacaswell
Copy link
Member

result = next(iter(done)).result()E       playwright._impl._api_types.Error: Executable doesn't exist at /home/vsts/.cache/ms-playwright/chromium-1015/chrome-linux/chromeE       ╔════════════════════════════════════════════════════════════╗E       ║ Looks like Playwright was just installed or updated.       ║E       ║ Please run the following command to download new browsers: ║E       ║                                                            ║E       ║     playwright install                                     ║E       ║                                                            ║E       ║ <3 Playwright Team                                         ║E       ╚════════════════════════════════════════════════════════════╝

looks like we need some extra steps in the CI setup?

@QuLogic
Copy link
MemberAuthor

I'm not sure what to do about the screenshot test, as I really want to confirm that the figure is sent to the browser, but browsers differ in how they show the resize grip, which causes te comparison to fail.

Can you mask the resize grip by drawing a white rectangle on top using imagemagic?

Actually, I forgot we have access to which browser is running the test, so I could just have two test images... I'll see what the diff looks like.

timhoffm reacted with thumbs up emoji

@QuLogic
Copy link
MemberAuthor

So this is nearly working on GitHub Actions. The current failure is on macOS. For some reason, the canvas gets a border and it's black on Linux, but blue on macOS. There's also some slight difference in the resize grip size.

AppVeyor only fails one test, so it's likely a similar deal.

Azure passes on Linux, but fails on macOS and Windows, but on several more tests. I'm not sure why that is yet.

@QuLogicQuLogic marked this pull request as draftOctober 27, 2022 04:51
@QuLogicQuLogicforce-pushed thetest-webagg branch 4 times, most recently fromcbe2368 to427df9cCompareNovember 8, 2023 09:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@timhoffm@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp