Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
TST: Update Quantity test class#23523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
__array_ufunc__ should "return" rather than "raise" when somethingis not handled within it.
tacaswell approved these changesJul 30, 2022
I am a bit worried that coverage does not see this change, however I can confirm that this fixes a failing test for me locally. |
What fails on main: |
jklymak approved these changesJul 31, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJul 31, 2022
timhoffm added a commit that referenced this pull requestJul 31, 2022
…523-on-v3.5.xBackport PR#23523 on branch v3.5.x (TST: Update Quantity test class)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The class should
return NotImplementedrather thanraise NotImplementedError:https://numpy.org/devdocs/user/basics.subclassing.html#array-ufunc-for-ufuncsAllow unitless comparison operators to pass-through
Closes#23382
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).