Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
changed colorbar outline from a Line2D object to a Polygon object#2352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| self.outline = lines.Line2D( | ||
| xy[:, 0], xy[:, 1], color=mpl.rcParams['axes.edgecolor'], | ||
| linewidth=mpl.rcParams['axes.linewidth']) | ||
| self.outline = mpatches.Polygon( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The default zorder is 2 for Line2D and 1 for Patch objects, so maybe the zorder should be explicitly set to 2 here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
Obviously, as an API change, this will need some documentation, but other than that I have no hold-ups from switching from Line2D to Polygon. 👍 |
I guess this answers my question of if this really should have targeted 1.3.x instead of master. added entry to |
changed colorbar outline from a Line2D object to a Polygon object
fixes issue#2296