Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: reset to original DPI in getstate#23476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromtacaswell:fix/unpickle_dpi
Jul 22, 2022

Conversation

tacaswell
Copy link
Member

PR Summary

There is a bit of extra caution in extracting the original DPI
just in case there is a canvas class that does something very funny
and the_orignial_dpi attribute does not get set (it is set to theFigure
instance in theCanvasBase init, not in theFigure init).

closes#23471

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

There is a bit of extra caution in extracting the original DPIjust in case there is a canvas class that does something very funnyand the `_orignial_dpi` attribute does not get set (it is set to the `Figure`instance in the `CanvasBase` init, not in the `Figure` init).closesmatplotlib#23471
@tacaswelltacaswell added this to thev3.5.3 milestoneJul 22, 2022
@QuLogicQuLogic merged commit3301248 intomatplotlib:mainJul 22, 2022
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.5.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 330124862b46dc003ff3e38427efcc9000b9d7ab
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #23476: FIX: reset to original DPI in getstate'
  1. Push to a named branch:
git push YOURFORK v3.5.x:auto-backport-of-pr-23476-on-v3.5.x
  1. Create a PR against branch v3.5.x, I would have named this PR:

"Backport PR#23476 on branch v3.5.x (FIX: reset to original DPI in getstate)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@tacaswelltacaswell deleted the fix/unpickle_dpi branchJuly 22, 2022 21:42
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestJul 22, 2022
Merge pull requestmatplotlib#23476 from tacaswell/fix/unpickle_dpiFIX: reset to original DPI in getstate(cherry picked from commit3301248)
QuLogic added a commit that referenced this pull requestJul 22, 2022
…-v3.5.xBackport PR#23476: FIX: reset to original DPI in getstate
@greglucasgreglucas mentioned this pull requestJun 16, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.3
Development

Successfully merging this pull request may close these issues.

[Bug]: DPI of a figure is doubled after unpickling on M1 Mac
3 participants
@tacaswell@QuLogic@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp