Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Try running the pgf backend off the article class.#23443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
oscargus merged 1 commit intomatplotlib:mainfromanntzer:pgfarticle
Jul 22, 2022

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedJul 18, 2022•
edited
Loading

Apparently the minimal class is problematic from some use cases, and its
used discouraged (https://tex.stackexchange.com/questions/42114).

This does require loading hyperref using a standard usepackage, though.

While we're at it, remove the early font loading, which seems
unnecessary too. (Or we should add a test or a comment that shows a
case where it's needed.)

Closes#18271. Admittedly I don'tknow for sure that this won't break any use cases, but I don't see how to find that out without trying...

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

krabo0om reacted with hooray emoji
@QuLogic
Copy link
Member

I would say this probably needs an API note?

Apparently the minimal class is problematic from some use cases, and itsused discouraged (https://tex.stackexchange.com/questions/42114).This does require loading hyperref using a standard usepackage, though.While we're at it, remove the early font loading, which seemsunnecessary too.  (Or we should add a test or a comment that shows acase where it's needed.)
@anntzer
Copy link
ContributorAuthor

done.

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's see how it goes.

@oscargusoscargus added this to thev3.6.0 milestoneJul 22, 2022
@oscargusoscargus merged commit4d85f70 intomatplotlib:mainJul 22, 2022
@anntzeranntzer deleted the pgfarticle branchJuly 22, 2022 11:34
QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestAug 19, 2022
This follows frommatplotlib#23443 where pgf started using `article` instead of`minimal`, but the testing check was not updated for it.
@ArchangeGabriel
Copy link
Contributor

ArchangeGabriel commentedSep 15, 2024•
edited
Loading

Just a small question way after: has thestandalone class be considered. This is the standard option for… well, standalone figures (just to be clear, I don’t think there is an issue with usingarticle, at least I did not find any, but I was wondering what would change when usingstandalone instead as this is the recommended class for those things).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

PGF uses the minimal document class
4 participants
@anntzer@QuLogic@ArchangeGabriel@oscargus
[8]ページ先頭
©2009-2025 Movatter.jp