Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Consistently set label on axis with units#23417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 6 commits intomatplotlib:mainfromdstansby:unit-axis-label
Nov 26, 2022

Conversation

dstansby
Copy link
Member

PR Summary

Fixes#23416. The issue was an incorrect check on whether units needed to be updated.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@dstansbydstansby marked this pull request as ready for reviewJuly 12, 2022 15:50
timhoffm
timhoffm previously requested changesJul 12, 2022
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm convinced this is the wrong way. See#23416 (comment). Please discuss there. I'm blocking this until we've reached a conclusion there.

@timhoffmtimhoffm dismissed theirstale reviewJuly 21, 2022 21:23

Misunderstood the issue.

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogicQuLogic added this to thev3.7.0 milestoneNov 26, 2022
@QuLogicQuLogic merged commit4e059bc intomatplotlib:mainNov 26, 2022
@dstansbydstansby deleted the unit-axis-label branchNovember 26, 2022 10:37
tacaswell added a commit that referenced this pull requestFeb 22, 2023
Revert#23417 (Consistently set label on axis with units)
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 22, 2023
ksunden added a commit that referenced this pull requestFeb 23, 2023
…278-on-v3.7.xBackport PR#25278 on branch v3.7.x (Revert#23417 (Consistently set label on axis with units))
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak left review comments

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent y-axis unit label with plot/scatter
4 participants
@dstansby@QuLogic@jklymak@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp