Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Small cleanups to animation.#23370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dopplershift merged 1 commit intomatplotlib:mainfromanntzer:a
Jun 29, 2022
Merged

Conversation

anntzer
Copy link
Contributor

  • Don't hard-code/expose CREATE_NO_WINDOW on Windows (I'll aggressively
    remove the global without a deprecation here), taking advantage of the
    fact that the subprocess module now exposes the constant on Windows.
  • Clarify the documentation in the rcParams for ffmpeg_path and
    convert_path. 1) subprocess.Popen (which is really what we're using)
    is not exactly just searching in the $PATH -- see the big warning to
    that respect in the CPython docs. 2) One doesn't actually need to put
    an absolute path for convert on Windows -- Matplotlib now handles this
    transparently.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

- Don't hard-code/expose CREATE_NO_WINDOW on Windows (I'll aggressively  remove the global without a deprecation here), taking advantage of the  fact that the subprocess module now exposes the constant on Windows.- Clarify the documentation in the rcParams for ffmpeg_path and  convert_path.  1) subprocess.Popen (which is really what we're using)  is not exactly just searching in the $PATH -- see the big warning to  that respect in the CPython docs.  2) One doesn't actually need to put  an absolute path for convert on Windows -- Matplotlib now handles this  transparently.
@anntzeranntzer added this to thev3.6.0 milestoneJun 29, 2022
@dopplershiftdopplershift merged commit4f9ac38 intomatplotlib:mainJun 29, 2022
@anntzeranntzer deleted the a branchJune 29, 2022 22:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dopplershiftdopplershiftdopplershift approved these changes

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@dopplershift@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp